Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBSAN][VirtualJetProducer]Avoid creating vector of size zero for jet=1 #46581

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 1, 2024

This fixes the issue #44998
The change makes sure that we do not create (and reference) vector of zero size. This will avoid the runtime error [a].

Note that this might not be the correct fix, may be this section of code needs different treatment for fjJets==1

[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_2_UBSAN_X_2024-10-30-2300/pyRelValMatrixLogs/run/136.759_RunDoubleEG2016E/step3_RunDoubleEG2016E.log#/185-185

gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_vector.h:1124:34: runtime error: reference binding to null pointer of type 'struct value_type'


@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • workflow = 136.759

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_14_2_UBSAN_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46581/42469

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • RecoJets/JetProducers (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AnnikaStein, @ahinzmann, @clelange, @gkasieczka, @jdamgov, @jdolen, @mariadalfonso, @missirol, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal, @yslai this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2024

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4887b/42543/summary.html
COMMIT: baacf9d
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46581/42543/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

  • unknown
AddOnTest might have timed out: FAILED -  secs

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4887b/42565/summary.html
COMMIT: baacf9d
CMSSW: CMSSW_14_2_X_2024-11-03-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46581/42565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3604869
  • DQMHistoTests: Total failures: 425
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3604422
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 205 log files, 174 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b4f40a0 into cms-sw:master Nov 4, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants