-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UBSAN][VirtualJetProducer]Avoid creating vector of size zero for jet=1 #46581
Conversation
cms-bot internal usage |
test parameters:
|
please test for CMSSW_14_2_UBSAN_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46581/42469
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: AddOn AddOn Tests
|
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This fixes the issue #44998
The change makes sure that we do not create (and reference) vector of zero size. This will avoid the runtime error [a].
Note that this might not be the correct fix, may be this section of code needs different treatment for
fjJets==1
[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_2_UBSAN_X_2024-10-30-2300/pyRelValMatrixLogs/run/136.759_RunDoubleEG2016E/step3_RunDoubleEG2016E.log#/185-185